SAK-132 API calls for latest authZGroup info ought to return up-to-date provider information
Package: edu.ucdavis.sakai.component.authzGroup.DbAuthzGroupService
Package: edu.ucdavis.sakai.component.authzGroup.DbAuthzGroupService
Line 14
Remove logger declaration because you use the m_logger member in BaseAuthzGroupService.
Line 17
Add comment that "sakai.authzgroup.refresh.seconds" can/needs to be defined in sakai.propertis. Also add some comment regarding which timeout declaration has precedence. e.g. sakai.properties, spring components, hard coded.
Line 53, 57
I think getRealmsRefreshed and setRealmsRefreshed are never used. So they may be removed.
Line 67
Remove comment. This doesn't seem to be applicable anymore.
Line 83
Remove second semicolon
Line 89, 93
Only create setter methods for spring injection. Spring doesn't need a getter method. If you create a getter method to be used just by this class, make it private
e.g.
// This method is not needed by spring. If you need it for internal use, make it private
public int getRefreshTimeoutSeconds() {
return refreshTimeoutSeconds;
}
public void setRefreshTimeoutSeconds(int refreshTimeoutSeconds) {
if(m_logger.isWarnEnabled()) {
m_logger.warn("setter for authzGroup refresh changed timeout from " +
this.refreshTimeoutSeconds + " to " + refreshTimeoutSeconds);
}
this.refreshTimeoutSeconds = refreshTimeoutSeconds;
}